sindresorhus/eslint-plugin-unicorn

`no-unnecessary-polyfills`: respect `.browserslistrc`

Open

#2,389 opened on Jun 24, 2024

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
enhancementevaluatinghelp wanted

Description

Description

Currently it will respect a browserlist field in package.json but it would be great if it could also respect the .browserslistrc file.

This will be a little more complicated though as that file can define multiple targets, so an option as to which target to respect would also need to be added, defaulting to production.

Fail

# .browserslistrc

[production]
since 2024

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Pass

# .browserslistrc

[production]
since 2020

[development]
last 1 version

if (!("groupBy" in Object)) {
  import("object.groupby").then(({ shim }) => shim())
}

Additional Info

No response

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of ESLint pluginsFamiliarity with browserslistWorking knowledge of Node.js file system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the current implementation of browserslist support in the plugin, likely in the `no unnecessary polyfills` rule. Look for how the `browserslist` field from `package.json` is read and used. Then implement parsing of `.browserslistrc` file, which can have multiple sections. Add a new option (e.g., `browserslistTarget`) defaulting to `production`. Ensure to use the `browserslist` package's API for parsing configuration. Consider integrating with existing logic to merge options. No PR linked; the issue has no comments.