sindresorhus/eslint-plugin-unicorn

False positive `array-from-async` in `unicorn/no-unnecessary-polyfills`

Open

#2,270 opened on Feb 6, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
bughelp wanted

Description

Code:

import arrayFromAsync from "array-from-async"; // Error: Use built-in instead

package.json:

{
  "engines": {
    "node": ">=18"
  }
}

Array.fromAsync is not present in any Node.js version, not even v21, so it should not trigger no-unnecessary-polyfills.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the implementation of the `no unnecessary polyfills` rule in the repository. The rule likely maintains a list of built in objects that are polyfillable. Determine where the check for `array from async` occurs and why it incorrectly flags it. The fix may involve adding `Array.fromAsync` to a list of APIs not available in Node.js, or modifying the version detection logic.