sindresorhus/eslint-plugin-unicorn

`unicorn/no-invalid-remove-event-listener` does not report when optional chaining

Open

#2,253 opened on Jan 12, 2024

View on GitHub
 (1 comment) (3 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
bughelp wanted

Description

Similar to #2252 but on unicorn/no-invalid-remove-event-listener

Rule works correctly without optional chaining:

However with optional chaining stops reporting error:

this.input?.removeEventListener(event, this.onInputEvent.bind(this), true)

Can be easily tested by adding ? after el: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/f0ff04d/test/no-invalid-remove-event-listener.mjs#L49

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLint plugin internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the rule's implementation to handle optional chaining in the callee object. Modify the rule to traverse OptionalMemberExpression nodes. Add a test case in test/no invalid remove event listener.mjs with optional chaining. Refer to similar issue #2252 for precedent.
`unicorn/no-invalid-remove-event-listener` does not report when optional chaining · sindresorhus/eslint-plugin-unicorn#2253 | Good First Issue