sindresorhus/eslint-plugin-unicorn

`no-nested-ternary` does not autofix nested ternary

Open

#2,008 opened on Dec 7, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
docshelp wantedwontfix

Description

var cellText = isYear
    ? i
    : isMonth
        ? settings.text.monthsShort[i]
        : isDay
            ? cellDate.getDate()
            : module.helper.dateFormat(formatter.cellTime, cellDate);

When the rule can autofix ternary (add parenthesis around), I would expect it to fix any level of nesting.

Currently it seems it can autofix only 2 nested ternary operators.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of ESLint rule structureFamiliarity with AST traversal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the source file `source/rules/no nested ternary.js` to understand how autofix is currently implemented for two level nesting. Look for the fix function that adds parentheses and determine how to extend it to recursively handle any depth of nested ternary operators. Check the existing tests to see coverage and add test cases for triple nesting or more.