sindresorhus/eslint-plugin-unicorn
Rule proposal: Prevent mistake in `Map` access
Closed
#1,663 opened on Dec 28, 2021
help wantednew rule
Repository metrics
- Stars
- (5,022 stars)
- PR merge metrics
- (Avg merge 1d 16h) (399 merged PRs in 30d)
Description
Description
Prevent mistake when check existence with .has(), but .get() or .set() with another key, I believe this is mistake in most cases. Especially in ternary.
Fail
const foo = map.has(key) ? map.get(anotherKey) : value;
if (!map.has(key)) {
const foo = map.get(anotherKey);
}
if (!map.has(key)) {
map.set(anotherKey, value);
}
Pass
const foo = map.has(key) ? map.get(key) : value;
if (map.has(key)) {
map.set(key, value);
map.set(anotherKey, value);
}