sindresorhus/eslint-plugin-unicorn

`expiring-todo-comments` should not throw in the recommended setting

Open

#1,207 opened on Apr 24, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (5,022 stars) (468 forks)user submission
enhancementhelp wanted

Description

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/b1a5f5341357f63094addd972c896c08624b73f4/index.js#L50

You don't want lint to start failing automatically on a set date, generally, so I'd suggest setting it to warn instead of error

no-warning-comments is also set to warn:

https://github.com/xojs/eslint-config-xo/blob/dd613d331eb3af44137cfbac69cc51de87b7f3f5/index.js#L180

Alternative solutions in my comment:

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
none
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
Locate the file `index.js` in the eslint plugin unicorn repository at line 50. Change the severity of the `expiring todo comments` rule from 'error' to 'warn' in the recommended config. Ensure that the change is consistent with similar rules like `no warning comments` which is set to 'warn' in eslint config xo.