sindresorhus/electron-unhandled

Add a filter option

Open

#18 opened on Apr 1, 2020

View on GitHub
 (7 comments) (7 reactions) (0 assignees)JavaScript (464 stars) (27 forks)user submission
enhancementhelp wanted

Description

It would be great if we had a configurable filter function that, if defined in the options, gets called BEFORE the options.logger and showMessageBox function get called and returns true or false to decide if the error should pass or not.

That way one could filter out error messages like ERR_CONNECTION_REFUSED that are not catchable

Contributor guide

Tech stack
javascriptnodejselectron
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ElectronUnderstanding of error handling in JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue requests a filter option in the electron unhandled library. The implementation would involve adding a `filter` function to the options object that receives the error and returns a boolean. The main handler in the library should check the filter before calling `options.logger` and `showMessageBox`. Relevant code is likely in the main module file, possibly `index.js` or `unhandled.js`. The maintainer has not provided further guidance, so contributors should review the existing codebase for pattern of option handling.