sindresorhus/electron-timber

Filter out Electron junk logging

Open

#13 opened on May 6, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (422 stars) (9 forks)user submission
enhancementhelp wanted

Description

See https://github.com/electron/electron/issues/12438#issuecomment-376667373

Electron logs a lot of annoying stuff and it doesn't seem like it will be fixed upstream anytime soon.

Here's what I get in the app I'm working on:

2018-05-07 02:20:07.532 Electron[5632:177578] *** WARNING: Textured window <AtomNSWindow: 0x7f951ec62830> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.
2018-05-07 02:20:08.440 Electron Helper[5635:177698] Couldn't set selectedTextBackgroundColor from default ()
[5632:0507/022008.491482:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)
[5632:0507/022009.415028:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)
[5632:0507/022010.414003:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)
[5632:0507/022011.413684:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)
[5632:0507/022012.415183:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)
[5632:0507/022013.415071:ERROR:CONSOLE(7574)] "Extension server error: Operation failed: : has no execution context", source: chrome-devtools://devtools/bundled/inspector.js (7574)

Another error we should filter out:

[93943:0510/142524.901813:ERROR:CONSOLE(105)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/inspector.js (105)

Contributor guide

Tech stack
javascriptnodejs
Domain
desktopdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScript knowledgefamiliarity with Electron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current logger implementation in the repository's main file (likely index.js). Identify where console messages are passed through. Implement filtering logic to suppress messages matching the given patterns: the warning about 'Textured window' and errors from 'CONSOLE(7574)' and 'CONSOLE(105)'. Consider adding an optional configuration or simple regex based filter. Reference the upstream Electron issue (https://github.com/electron/electron/issues/12438) for context.
Filter out Electron junk logging · sindresorhus/electron-timber#13 | Good First Issue