sindresorhus/electron-store

Default Behaviour for `store.get(undefined)`

Open

#283 opened on Sep 30, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (4,304 stars) (150 forks)batch import
enhancementhelp wanted

Description

I've just realized that the default behavior of getting undefined resolves the entire store w/any error or warning. Is an error or warning desirable for case of bad input args?

let u;
let storedu = store.get(u);
console.log(storedu);
// Lists entire contents of the satore

If so, happy to PR.

Contributor guide

Tech stack
javascriptnodejselectron
Domain
apideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptelectron store usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the current implementation of the `get` method in the electron store source (likely `index.js`). Determine if there is any existing input validation. Decide whether to throw an error or console.warn for undefined input. Consider adding a test for this case. After deciding, implement the change and submit a PR.