sindresorhus/electron-store

Default Behaviour for `store.get(undefined)`

Open

#283 opened on Sep 30, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (150 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (4,304 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've just realized that the default behavior of getting undefined resolves the entire store w/any error or warning. Is an error or warning desirable for case of bad input args?

let u;
let storedu = store.get(u);
console.log(storedu);
// Lists entire contents of the satore

If so, happy to PR.

Contributor guide

Research direction
Add validation to `store.get` to throw an error or log a warning when `undefined` is passed as the key.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80