sindresorhus/electron-reloader

Support Hot Module Replacement (HMR)

Open

#1 opened on Jan 29, 2018

View on GitHub
 (0 comments) (7 reactions) (0 assignees)JavaScript (585 stars) (45 forks)user submission
enhancementhelp wanted

Description

https://webpack.js.org/concepts/hot-module-replacement/

Would be useful so people could totally replace their server (For example webpack-dev-server) with this module and electron-serve.

Since we have access to the window, I don't think we need all the websocket boilerplate, so we could just modify the page directly.

Some resources: https://github.com/glenjamin/webpack-hot-middleware/blob/master/process-update.js https://github.com/webpack/webpack-dev-server/blob/b0fa5f634e82ce942ac79f1b1371ef7f5afcdc81/client-src/live/index.js

Contributor guide

Tech stack
javascriptnodejs
Domain
desktopdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Electron's main/renderer processKnowledge of webpack HMR conceptsFamiliarity with electron reloader's codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Start by examining the provided resources: the webpack hot middleware process update.js and webpack dev server live/index.js. Understand how they handle HMR updates via websockets. Since electron reloader runs in the same process, we can directly modify the page without websockets. Investigate how to intercept webpack's HMR runtime and apply updates to the Electron renderer. Look at the electron reloader source code to see how it currently reloads and integrate the hot update logic there.