sindresorhus/electron-dl

BUG: Promise is not working correctly

Open

#67 opened on Jul 5, 2018

View on GitHub
 (3 comments) (3 reactions) (0 assignees)JavaScript (136 forks)user submission
bughelp wanted

Repository metrics

Stars
 (1,206 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

#66

download This library works correctly for same syntax

Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(x, 'dist');
})).then(function () {
    console.log('files downloaded!');
});

electron-dl: while using same with electron-dl does not. Promise returns before downloads


  Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(BrowserWindow.getFocusedWindow(), x);
  })).then(function (x) {
    console.log('files downloaded!');
  });

Contributor guide