sindresorhus/electron-dl

BUG: Promise is not working correctly

Open

#67 opened on Jul 5, 2018

View on GitHub
 (3 comments) (3 reactions) (0 assignees)JavaScript (1,206 stars) (136 forks)user submission
bughelp wanted

Description

#66

download This library works correctly for same syntax

Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(x, 'dist');
})).then(function () {
    console.log('files downloaded!');
});

electron-dl: while using same with electron-dl does not. Promise returns before downloads


  Promise
.all(['https://download.filezilla-project.org/client/FileZilla_3.34.0_win64-setup_bundled.exe', 'http://the.earth.li/~sgtatham/putty/latest/w32/putty-0.70-installer.msi', 'http://speedtest.ftp.otenet.gr/files/test10Mb.db']
.map(function (x) {
    return download(BrowserWindow.getFocusedWindow(), x);
  })).then(function (x) {
    console.log('files downloaded!');
  });

Contributor guide

Tech stack
javascriptnodejs
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript promisesElectron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the implementation of the download function in electron dl vs the download library. Compare how promises are handled, particularly the return value. Check if the function returns a promise that resolves after the download completes. Look at the source code file (likely index.js). The user reports that Promise.all resolves before downloads finish, so the download function might not return a proper promise or might not await the underlying download. Ensure that the download function returns a promise that resolves when the download is done. Also check if there is any event listener that might cause premature resolution. Consider referencing the similar library kevva/download for correct pattern.