sindresorhus/electron-dl

Alert when download completes

Open

#32 opened on Nov 8, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,206 stars) (136 forks)user submission
enhancementhelp wanted

Description

Hi - nice lib - really usefull!

I am not extremely experienced so would appreciate if you could show an example or explain how to handle the completion event?

I currently have the following in my main.dev.js file and would like to have some way of handling the completion of the download (instead of opening the folder):

import { app, BrowserWindow } from 'electron';
...
require('electron-dl')({openFolderWhenDone:true});
...

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptElectron module structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the main module (index.js) where the download function is called. Add a 'done' event to the downloaded item or allow a callback option. Check the existing options like openFolderWhenDone for reference. Ensure compatibility with Electron's download item API.