sindresorhus/electron-dl

Alert when download completes

Open

#32 opened on Nov 8, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (136 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (1,206 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi - nice lib - really usefull!

I am not extremely experienced so would appreciate if you could show an example or explain how to handle the completion event?

I currently have the following in my main.dev.js file and would like to have some way of handling the completion of the download (instead of opening the folder):

import { app, BrowserWindow } from 'electron';
...
require('electron-dl')({openFolderWhenDone:true});
...

Contributor guide

Research direction
Examine the module's source code to identify where downloads complete and add an event emitter or callback for the completion event.
Tech stack
javascriptelectron
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70