sindresorhus/electron-dl

Provide access to receivedBytes and totalBytes

Open

#31 opened on Oct 27, 2017

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (136 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (1,206 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Perhaps in the onProgress handler? It could receive a second parameter with a details object. The signature could look something like this:

{
  receivedBytes,
  totalBytes,
  item,
}

Further expanding on this idea, it could also include useful info like eta (estimated time remaining in milliseconds) and bps (current bytes per second). These would be handy but are less important as they can be calculated outside of the module using receivedBytes, totalBytes and a setTimeout.

Contributor guide

Research direction
Examine the onProgress callback implementation and the download function to add a details object with receivedBytes, totalBytes, item, and optionally eta and bps.
Tech stack
javascript
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptElectronGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75