sindresorhus/electron-dl

Overwrite Option is flase. but, the same file name is specified in the directory, it is overwritten.

Open

#144 opened on Oct 26, 2021

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (1,206 stars) (136 forks)user submission
bughelp wanted

Description

The overwrite option was false and the file option was used. If the file name is the same, it will continue to be overwritten with one file.

ex. filename : "a" The motion I want: "a", "a(1)" Current motion: "a"

Contributor guide

Tech stack
javascript
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsElectronFile handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the download function in index.js to find where the overwrite option is checked. The issue indicates that when overwrite is false, the file should be renamed (e.g., appending (1)) instead of overwritten. Look for the logic that handles file existence and ensure it respects the overwrite flag. Check if there are existing tests for this behavior.
Overwrite Option is flase. but, the same file name is specified in the directory, it is overwritten. · sindresorhus/electron-dl#144 | Good First Issue