sindresorhus/electron-context-menu

Error at <webview> using "save image"

Open

#98 opened on Feb 24, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,471 stars) (167 forks)user submission
bughelp wanted

Description

contextMenu({ window:document.getElementById('webview'), showCopyImage:true, showSaveImageAs:true, showCopyImageAddress:true, })

Uncaught (in promise) TypeError: Cannot read property 'session' of undefined at index.js:138 at new Promise (<anonymous>) at module.exports../node_modules/electron-dl/index.js.module.exports.download (index.js:135) at click (index.js:109) at CallbacksRegistry.apply (callbacks-registry.ts:45) at remote.js:292 at EventEmitter.<anonymous> (remote.js:272) at EventEmitter.emit (events.js:210) at Object.onMessage (init.ts:50)

Electron verson 8.0.0

Contributor guide

Tech stack
javascriptnodejs
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of ElectronUnderstanding of async/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the error trace: 'Cannot read property 'session' of undefined' occurs in electron dl's index.js when calling download. The issue likely stems from the webview element lacking a proper session. Check the electron context menu source file (index.js around line 109 and 135) and the electron dl library to understand how the session is accessed. Look at related issues in both repositories for similar reports. Consider testing with different Electron versions to see if the behavior is consistent.