sindresorhus/electron-context-menu

Error at <webview> using "save image"

Open

#98 opened on Feb 24, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (167 forks)user submission
bughelp wanted

Repository metrics

Stars
 (1,471 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

contextMenu({ window:document.getElementById('webview'), showCopyImage:true, showSaveImageAs:true, showCopyImageAddress:true, })

Uncaught (in promise) TypeError: Cannot read property 'session' of undefined at index.js:138 at new Promise (<anonymous>) at module.exports../node_modules/electron-dl/index.js.module.exports.download (index.js:135) at click (index.js:109) at CallbacksRegistry.apply (callbacks-registry.ts:45) at remote.js:292 at EventEmitter.<anonymous> (remote.js:272) at EventEmitter.emit (events.js:210) at Object.onMessage (init.ts:50)

Electron verson 8.0.0

Contributor guide

Research direction
Inspect the error trace. The issue is that 'session' is undefined when calling electron dl download function. Check if the webview element has a valid session property before calling download. The 'electron context menu' likely uses electron dl. Look at how the webview is passed and ensure it's a valid BrowserWindow or webview instance.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Electron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70