sindresorhus/electron-context-menu

Ability to hide "Copy Link" and "Save Link As" for `file://` protocol

Open

#152 opened on Nov 27, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,471 stars) (167 forks)user submission
enhancementhelp wanted

Description

Currently, the package allows copying links that are not really links and just internal files.

It would be awesome if there was a way to disable file:// links from being treated as links.

Alternatively, maybe we can pass a function instead of a callback into showCopyLink so we can fine-tune the behaviour.

Contributor guide

Tech stack
electronjavascript
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Electron basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how the context menu is built, specifically the addition of 'Copy Link' and 'Save Link As' items. Locate the source file(s) where link detection occurs. Explore the `showCopyLink` option and how it can be extended to accept a predicate function. Check existing tests to understand expected behavior and ensure backward compatibility.