sindresorhus/electron-context-menu

"Download" actions do not work in webviews

Open

#122 opened on Oct 20, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (167 forks)user submission
bughelp wanted

Repository metrics

Stars
 (1,471 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

"Download" actions pass the webview as a window to electron-dl, but electron-dl does not support webviews. Electron-dl would need to change its specification or electron-context-menu should pass the parent window instead.

Contributor guide

Research direction
Locate the download action handler in the context menu code. Identify where 'electron dl' is called and the window object is passed. Modify it to pass the parent window (webview's owner) instead of the webview itself. Refer to electron dl documentation for supported parameters.
Tech stack
javascript
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptGitElectron
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70