sindresorhus/electron-context-menu

"Download" actions do not work in webviews

Open

#122 opened on Oct 20, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,471 stars) (167 forks)user submission
bughelp wanted

Description

"Download" actions pass the webview as a window to electron-dl, but electron-dl does not support webviews. Electron-dl would need to change its specification or electron-context-menu should pass the parent window instead.

Contributor guide

Tech stack
javascript
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of ElectronFamiliarity with webviews
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the electron context menu source to find where download actions are triggered. Determine if the webview's window is passed incorrectly. Then examine electron dl to see if it can be modified to support webviews or if the parent window should be passed instead. The issue suggests two approaches: change electron dl's specification or modify electron context menu to pass the parent window.
"Download" actions do not work in webviews · sindresorhus/electron-context-menu#122 | Good First Issue