sindresorhus/do-not-disturb

Stop using polling for the `change` event

Open

#6 opened on Feb 18, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (223 stars) (21 forks)user submission
enhancementhelp wanted

Description

Could use the same method of doing it as https://github.com/LinusU/DarkModeListener/blob/master/Sources/main.swift and https://github.com/LinusU/node-dark-mode-listener

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift programmingmacOS event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the current polling implementation in the repository, likely in the main Swift file. Study the referenced implementations (DarkModeListener and node dark mode listener) to understand the alternative approach used for change events. Implement a similar method using macOS's distributed notification center or KVO to replace the polling mechanism.