sindresorhus/del

Async throw error delay

Open

#98 opened on Jul 12, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,305 stars) (71 forks)batch import
enhancementhelp wanted

Description

Would you accept a PR that would change how async errors are thrown so the error is thrown after all pending files being deleted are removed? This would help deal with side effects a lot cleaner, especially when testing.

Similar to https://github.com/sindresorhus/del/pull/90.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js async/awaiterror handling patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the existing error handling in the del library, focusing on the async file deletion logic. Review linked PR #90 for a similar approach. Test how errors are currently thrown during pending deletions and propose a change to defer the error until all deletions complete.