sindresorhus/del

Async throw error delay

Open

#98 opened on Jul 12, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (71 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,305 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Would you accept a PR that would change how async errors are thrown so the error is thrown after all pending files being deleted are removed? This would help deal with side effects a lot cleaner, especially when testing.

Similar to https://github.com/sindresorhus/del/pull/90.

Contributor guide

Research direction
Investigate the current async error handling in the del package and review the linked PR #90 to understand the proposed pattern for deferring errors until synchronous cleanup completes.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptasync/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70