sindresorhus/del

Add default concurrency limit

Open

#60 opened on Jun 9, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (1,305 stars) (71 forks)batch import
enhancementhelp wanted

Description

Currently the concurrency limit is Infinity. I have a gut feeling it would generally be faster with some kind of concurrency limit. Probably a number between 4 and 10. This will need some benchmarking. Help wanted.

Context: https://github.com/sindresorhus/del/commit/66f069f1dedb7d077bc35b9d6c50f278418ff34c#commitcomment-21722984

Contributor guide

Tech stack
javascriptnodejs
Domain
backendcli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js asyncbenchmarkingconcurrency concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate current concurrency implementation in the del repo (likely in the main module). Run benchmarks with different concurrency limits (4-10) to compare performance against Infinity. Decide on a default value based on results, then implement the change and ensure existing tests pass. Consider adding a configurable option as well.