sindresorhus/del

Add default concurrency limit

Open

#60 opened on Jun 9, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (71 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,305 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently the concurrency limit is Infinity. I have a gut feeling it would generally be faster with some kind of concurrency limit. Probably a number between 4 and 10. This will need some benchmarking. Help wanted.

Context: https://github.com/sindresorhus/del/commit/66f069f1dedb7d077bc35b9d6c50f278418ff34c#commitcomment-21722984

Contributor guide

Research direction
Examine the current file deletion loop and add a concurrency limiter (e.g. using p limit). Benchmark with different limits (4-10) to find optimal performance.
Tech stack
javascriptnodejs
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65