sindresorhus/alfred-npms

RequestError: read ECONNRESET

Open

#31 opened on Feb 1, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (367 stars) (24 forks)user submission
enhancementhelp wanted

Description

Environment

  • MacOS Monterey 12.1
  • Node v16.13.2
  • Alfred 4.6.2

When I type anything, an error occurs.

"items": [
	{
		"title": "RequestError: read ECONNRESET",
		"subtitle": "Press ⌘L to see the full error and ⌘C to copy it.",
		"valid": false,
		"text": {
			"copy": "```\nRequestError: read ECONNRESET\n    at ClientRequest.<anonymous> (/Users/younho9/.nvm/versions/node/v16.13.2/lib/node_modules/alfred-npms/node_modules/got/dist/source/core/index.js:962:111)\n    at ClientRequest.origin.emit (/Users/younho9/.nvm/versions/node/v16.13.2/lib/node_modules/alfred-npms/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)\n```\n\n-\nnpms 3.0.0\nAlfred 4.6.2\ndarwin 21.2.0",
			"largetype": "RequestError: read ECONNRESET\n    at ClientRequest.<anonymous> (/Users/younho9/.nvm/versions/node/v16.13.2/lib/node_modules/alfred-npms/node_modules/got/dist/source/core/index.js:962:111)\n    at ClientRequest.origin.emit (/Users/younho9/.nvm/versions/node/v16.13.2/lib/node_modules/alfred-npms/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)"
		},
		"icon": {
			"path": "/System/Library/CoreServices/CoreTypes.bundle/Contents/Resources/AlertStopIcon.icns"
		}
	}
]

I found this issue comment, https://github.com/request/request-promise/issues/147#issuecomment-349148433, and I added Connection: 'keep-alive' header to alfred-npms/node_modules/alfy/index.js:137 then the error has been resolved.

response = await got(url, {headers: {Connection: 'keep-alive'}, searchParams: options.query}).json();

Is there anyone else who experiences this error? I wonder if should add a Connection: 'keep-alive' header to the alfy.fetch.

Contributor guide

Tech stack
javascriptnodejs
Domain
desktoptooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is a network error (ECONNRESET) when using the Alfred workflow. The reporter found a fix by adding a 'Connection: keep alive' header to the HTTP request in the 'alfy' module's fetch function. The fix should be applied either in the 'alfred npms' repository or in the upstream 'alfy' module. Since this is a simple one line change, a contributor can create a pull request adding the header. The relevant file is likely 'node modules/alfy/index.js' but the proper fix should be applied to the source code of 'alfy' or 'alfred npms' depending on where the HTTP request is made. The maintainer has not yet responded, so the issue is fresh and available for contribution.