sindresorhus/Settings

Make it work automatically when used in a menu bar app

Open

#40 opened on Aug 1, 2019

View on GitHub
 (11 comments) (2 reactions) (0 assignees)Swift (1,534 stars) (123 forks)user submission
enhancementhelp wanted

Description

I make an app, just with statusbar and menu item. And I add preferences in the menu item. But when the Preferences open, I can't use cmd+w close it. Only has to click red close button in the left up corner.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftmacOS AppKit basicskeyboard event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the current Settings window implementation to understand how it handles keyboard events. Look for the window controller class and check if it overrides keyDown or performKeyEquivalent methods. Implement handling for cmd+W to close the window, similar to standard macOS behavior. Consider adding a menu item or key equivalent for the close action.