sindresorhus/Plash

Fade in the web view

Open

#9 opened on Jan 9, 2020

View on GitHub
 (0 comments) (2 reactions) (0 assignees) (157 forks)user submission
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (3,961 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be nice to fade in the web view when the page has loaded. Right now, it just shows a gray background on the first start until the page loads.

https://github.com/sindresorhus/Plash/blob/a6aa255e4561ddc7f49a2b5a2aa1f46939cc8d7f/Plash/AppDelegate.swift#L139-L143

Here are some fade utilities: https://github.com/sindresorhus/Gifski/blob/5602861e7cf1970dcf19442e546e70d74cc30d58/Gifski/util.swift#L1397-L1428

Contributor guide

Research direction
Add a fade in animation to the web view when the page finishes loading. Use the fade utilities from the linked file to animate the web view's alpha from 0 to 1. Modify the web view delegate's didFinishLoad method to trigger the animation.
Tech stack
swift
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftXcode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75