sindresorhus/Plash

Fade in the web view

Open

#9 opened on Jan 9, 2020

View on GitHub
 (0 comments) (2 reactions) (0 assignees) (3,961 stars) (157 forks)user submission
enhancementgood first issuehelp wanted

Description

It would be nice to fade in the web view when the page has loaded. Right now, it just shows a gray background on the first start until the page loads.

https://github.com/sindresorhus/Plash/blob/a6aa255e4561ddc7f49a2b5a2aa1f46939cc8d7f/Plash/AppDelegate.swift#L139-L143

Here are some fade utilities: https://github.com/sindresorhus/Gifski/blob/5602861e7cf1970dcf19442e546e70d74cc30d58/Gifski/util.swift#L1397-L1428

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Swift knowledgeXcode
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue asks to fade in the web view when the page loads, currently showing a gray background. The relevant code is in Plash/AppDelegate.swift at lines 139-143. The repository includes fade utilities in Gifski/util.swift (lines 1397-1428) that can be adapted. Implement an animation that changes the web view's alpha from 0 to 1 once loading completes, using NSView.animator() or similar.
Fade in the web view · sindresorhus/Plash#9 | Good First Issue