sindresorhus/Plash

After macOS waking up without internet connection, no website is shown

Open

#41 opened on Feb 4, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees) (3,961 stars) (157 forks)user submission
bughelp wanted

Description

Describe the bug

I'm working on different setups where one has internet through WLAN and the other over LAN. When switching workplaces (opening/closing the lid) it seems Plash can not reload the web page or get back to the last state.

To reproduce

Steps to reproduce the behavior:

  1. Open any website
  2. Turn off w-lan
  3. Close the lid
  4. Open the lid
  5. red Plash icon
  6. no website

Expected behavior

Saving the last state and waiting for a new internet connection or use a service worker to save the site offline.

Screenshots

If applicable, add screenshots to help explain your problem.

Info

  • macOS version: 10.15.2
  • Plash version: latest (don't know where I can see this, mabye add the version and hash as read only menu item)

Additional context

Add any other context about the problem here.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
macOS development experienceSwift knowledgeWebKit basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how Plash handles network state changes when waking from sleep. Look at the WKWebView usage in the source code (likely in Swift) and check if there's a mechanism to reload or cache the page. Consider adding network reachability monitoring and reloading the web view when network becomes available. Also explore using `WKWebsiteDataStore` for caching or implementing a service worker if the website supports it. Refer to Apple's documentation on handling network transitions.