sindresorhus/Plash

The new disable shortcut hook is great, I'd like a similar "pause/unpause" shortcut

Open

#154 opened on Jan 24, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees) (3,961 stars) (157 forks)user submission
enhancementhelp wanted

Description

I use a website for plash that play video playlists as a background

The shortcut to disable/re-enable is great, but it causes my playlist position to be lost as plash does not save the current URL and always reloads to the website's home page.

I'd like a pause shortcut action that hides the plash background and pauses the renderer, and corresponding unpause that does the opposite.

Alternately, if plash could save/restore the current url when disabling/enabling that would be almost as good.

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift programmingmacOS app developmentKeyboard shortcut handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Study the implementation of the existing disable shortcut in the codebase (likely in the AppDelegate or a shortcuts handler). Understand how to programmatically pause the web renderer (e.g., using WKWebView's pauseAllMediaPlayback or similar) and hide the window. Check comments on the issue for any maintainer feedback on preferred approach. The payload could be similar to the disable shortcut but toggling visibility and pausing media.