sindresorhus/Gifski

Support showing video transparency in the editor

Open

#237 opened on Mar 14, 2021

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Swift (8,383 stars) (315 forks)batch import
enhancementhelp wanted

Description

Currently, the video player in the editor just shows a black background for videos with an alpha channel. I think this is a limitation in AVPlayerView, but if anyone knows a way to make it work, let me know. According to this session from WWDC 2019, AVPlayer should support videos with alpha channel.

Here's a sample video: puppets_with_alpha_hevc.mov.zip

Feedback Assistant report: https://github.com/feedback-assistant/reports/issues/197

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of AVFoundationFamiliarity with macOS app development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate AVPlayerView subclassing to handle alpha channel rendering. Refer to the WWDC 2019 session linked in the issue for guidelines on AVPlayer alpha support. Test with the provided sample video (puppets with alpha hevc.mov). Check the Feedback Assistant report for any additional insights.