sindresorhus/Defaults

Use `Color.Resolved` to serialize `Color` on macOS 14+

Open

#143 opened on Jun 16, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Swift (2,465 stars) (162 forks)user submission
enhancementhelp wanted

Description

https://developer.apple.com/documentation/swiftui/color/resolve(in:) https://developer.apple.com/documentation/swiftui/color/resolved

It should be able to store the color better than what we currently do. We still need to preserve backwards compatibility, so we can first try loading it as Color.Resolved and if it fails, we can use the old way.

Color.Resolved is Codable, so we should use that for the serialization.

Contributor guide

Tech stack
swift
Domain
desktopapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift programmingCodable protocolUserDefaults basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look into the current Color serialization code in the Defaults library, likely in Defaults+Color.swift. Implement a conditional approach: attempt to decode using Color.Resolved (Codable) on macOS 14+, and fall back to the old serialization if that fails. Ensure backward compatibility with older macOS versions. Test with different Color instances to verify correctness.
Use `Color.Resolved` to serialize `Color` on macOS 14+ · sindresorhus/Defaults#143 | Good First Issue