Support for storage system of type `file` broken

Open Beginner friendly
#538 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start in simvue/factory/proxy/remote.py and trace the response from the POST to /api/artifacts. Verify the file-upload path only runs when the returned url is not None; for a file storage system with a None url, done means no upload is attempted and the artifact reference is retained.

Written by the indexing model from the issue text.

Description

bug

In simvue/factory/proxy/remote.py it tries to upload a file if url is in the JSON response to the POST to /api/artifacts. However, for the case of a storage system of type file, where you just store references to files, the client shouldn't try to upload a file.

If the url is None the upload shouldn't be attempted. Currently the client tries to upload a file to None which fails of course.

Dominant language
Python
Stars
4
Forks
1
Avg merge
5d 8h
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simvue-io/python-api

All issues in simvue-io/python-api

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.