test module with redirectTrustedURL

Open

#3 opened on Dec 1, 2023 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 25/100

Issue type: Bug
Clarity: Needs clarification
Activity status: Stale
Tech stack: php
Domain: testing

Research direction

Start by reproducing the failure in tests/src/Auth/Process/ExpiryDateTest.php, then trace the call from src/Auth/Process/ExpiryDate.php:191 into SimpleSAML/Utils/HTTP.php:1011. Check the test framework setup around redirectTrustedURL and define done as the unit test completing without the InvalidArgumentException.

Written by the indexing model from the issue text.

Description

I am trying to write some unit tests to https://github.com/simplesamlphp/simplesamlphp-module-expirycheck/

is it possible to test Auth\ProcessingFilter in a module which uses a $httpUtils->redirectTrustedURL?

$filter->process($request);

https://github.com/simplesamlphp/simplesamlphp-module-expirycheck/blob/211ed0f229df807e3def38d55d1a42c89e406a04/src/Auth/Process/ExpiryDate.php#L191

throws this exception

InvalidArgumentException: Unable to parse base url: http://localhost

/xxx/simplesamlphp-module-expirycheck/vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php:1011
/xxx/simplesamlphp-module-expirycheck/vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php:886
/xxx/simplesamlphp-module-expirycheck/vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/HTTP.php:954
/xxx/simplesamlphp-module-expirycheck/src/Auth/Process/ExpiryDate.php:191
/xxx/simplesamlphp-module-expirycheck/tests/src/Auth/Process/ExpiryDateTest.php:170

ERRORS!
Tests: 17, Assertions: 40, Errors: 1, Warnings: 1.

any help is welcome

Regards

Dominant language: PHP
Stars: 0
Forks: 2
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

google-cloud-php: remove format step from owlbot.py now that librarian runs formatting during generate Open

priority: p3

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

googleapis/librarian#7636 · Opened Sep 21, 2026
occ fulltextsearch:document:index without --collection throws Exception before v35 Open

0. Needs triage bug

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

nextcloud/fulltextsearch#1011 · Opened Sep 21, 2026
bench results do not distinguish mirror-cold from network-cold Open

Difficulty 2/5 1-3 hours Newbie friendliness 84/100

svandragt/vivace#292 · Opened Sep 21, 2026
Narrow argument types in the new Pagination\Window class in ORM 3.7 Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

phpstan/phpstan-doctrine#794 · Opened Sep 21, 2026
Homeboy findings in static-site-importer Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

Automattic/static-site-importer#1767 · Opened Sep 21, 2026

More PHP issues