writeMetadataPdo surplus configuration

Open
#47 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
database

Research direction

Start at MetaLoader.php:675 and inspect the construction of Metadata\MetaDataStorageHandlerPdo, then compare it with that class's constructor and its use of Database::getInstance(). Determine whether the surplus configuration should be removed or handled consistently, and verify that the constructor warning no longer appears.

Written by the indexing model from the issue text.

Description

There's a Too many arguments to function __construct(). 2 provided, but 1 accepted. warning being picked up in MetaLoader.php:675

The constructor on Metadata\MetaDataStorageHandlerPdo accepts one config parameter but then doesn't do anything with it anyway, calling Database::getInstance(); instead.

My inclination was to drop passing the config in the metarefresh module entirely but not sure if that's the right approach.

Dominant language
PHP
Stars
9
Forks
19
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simplesamlphp/simplesamlphp-module-metarefresh

All issues in simplesamlphp/simplesamlphp-module-metarefresh

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.