Upstream sent duplicate header line

Open
#24 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
nginx, php
Domain
backend

Research direction

Start by reproducing the GET request to module.php/discopower/disco.php against dev-master and the latest release, while inspecting the response headers and the nginx log. Trace where the duplicate Date header is produced; done means the request no longer emits duplicate Date headers without affecting the rest of SSP.

Written by the indexing model from the issue text.

Description

Hi team, When using discopower I notice the following in the logs when looking at disco.php. On both dev-master and latest release.

2024/08/21 03:28:41 [warn] 286#286: *4918 upstream sent duplicate header line: "Date: Wed, 21 Aug 2024 03:28:41 GMT", previous value: "Date: Wed, 21 Aug 2024 03:28:41 GMT", ignored while reading response header from upstream, client: x.x.x.x, server: x.x.x.x, request: "GET /simplesaml/module.php/discopower/disco.php?entityID=https%3A%2F%2Fx.x.x.x%2Fsimplesaml%2Fmodule.php%2Fsaml%2Fsp%2Fmetadata.php%2Fdefault-sp&return=https%3A%2F%2Fx.x.x.x%2Fsimplesaml%2Fmodule.php%2Fsaml%2Fsp%2FdiscoResponse%3FAuthID%3D_889a13be559c3295def3f9745d42df88a4d1fd33ca%253Ahttps%253A%252F%252Fx.x.x.x%252Fsimplesaml%252Fmodule.php%252Fsaml%252Fsp%252Flogin%252Fdefault-sp%253FReturnTo%253Dhttps%25253A%25252F%25252Fx.x.x.x%25252F%25253Fs%25253Dupload&returnIDParam=idpentityid HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "x.x.x.x", referrer: "https://x.x.x.x"

The rest of SSP seems to not have this problem.

Dominant language
PHP
Stars
5
Forks
11
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simplesamlphp/simplesamlphp-module-discopower

All issues in simplesamlphp/simplesamlphp-module-discopower

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.