Theme colour overrides
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- scss
- Domain
- frontend
Research direction
Search the SCSS assets for the hard-coded #db0100 value and inspect _head.twig, which is the proposed place for theme overrides. Replace the repeated colour usage with consistently overridable variables, including the other colours where appropriate. Done means a style declaration in _head.twig can change the theme colour throughout the affected assets.
Written by the indexing model from the issue text.
Description
The #db0100 colour is hard-coded in several places in the SCSS, making it quite difficult for theme developers to override.
Doing something like:
:root {
--simplesamlphp-color: #db0100;
}
and then referencing it elsewhere as e.g.:
.pure-button-red {
background-color: var(--simplesamlphp-color);
color: #fff;
}
would make it much easier to override the colour consistently by simply declaring an additional <style> element in _head.twig with the new --simplesamlphp-color variable definition. The same could be done with the other colours that are used.
I'd do this as a pull request, but I think this repo has complexity I do not understand :-)
- Dominant language
- No language data
- Stars
- 0
- Forks
- 2
- Avg merge
- 8m
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simplesamlphp/simplesamlphp-assets-base
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in simplesamlphp/simplesamlphp-assets-base
Similar issues
-
S: triage
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
feature:Languages/Translations good first issue ready Web
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
digitalfabrik/integreat-app#4394 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
comp/desktop P3 type/bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
NousResearch/hermes-agent#118866 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/cloudstack#14222 ·