option to point --browser firefox at a custom executable?

Open Beginner friendly
#196 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
cli

Research direction

Search for p.firefox.launch() and the browser_args handling to find the CLI entry point. Add the optional executable-path behavior described in the issue, then verify that the CLI exposes it and that the launch call receives it.

Written by the indexing model from the issue text.

Description

shot-scraper launches the bundled firefox via p.firefox.launch() and exposes browser_args, but there's no way to point it at a different firefox build. would an optional executable path (e.g. --browser-executable, passed to launch as executable_path) be in scope? it'd let people use an alternative firefox for shots of pages that don't render well under the bundled headless one. small change to the launch call. happy to send a PR if you're open to it.

Dominant language
Python
Stars
2.6k
Forks
128
Avg merge
9d 15h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from simonw/shot-scraper

All issues in simonw/shot-scraper

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.