simonw/datasette

Get Datasette tests passing on Windows in GitHub Actions

Open

#511 opened on Jun 15, 2019

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
featurehelp wantedmedium

Description

This should almost happen as a side-effect or moving from Sanic to Uvicorn during the port to ASGI: #272

Additional steps:

  • test it manually
  • update documentation
  • set up some form of Windows CI

Contributor guide

Tech stack
pythongithub actions
Domain
testingci cd
Issue type
devops
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonDatasette basicsGitHub Actionspytest testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
First, check the current status of the ASGI port (#272) which may already resolve some Windows compatibility issues. Then, run the existing test suite on a Windows environment manually to identify failing tests. Look at the test configuration files (e.g., setup.cfg, pytest.ini) to understand the test framework. Consider adding a GitHub Actions workflow for Windows (see .github/workflows/) to run tests on push/PR. Update CONTRIBUTING.md or documentation with Windows setup instructions.
Get Datasette tests passing on Windows in GitHub Actions · simonw/datasette#511 | Good First Issue