simonw/datasette

sql-formatter javascript is not now working with CloudFlare rocketloader

Open

#1,969 opened on Dec 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (625 forks)batch import
bughelp wantedjavascript

Repository metrics

Stars
 (8,637 stars)
PR merge metrics
 (Avg merge 67d 23h) (19 merged PRs in 30d)

Description

This is probably not a bug with datasette, but I thought you might want to know, @simonw.

I noticed today that my CloudFlare proxied datasette instance lost the "Format SQL" option. I'm pretty sure it was there last week.

In the CloudFlare settings, if I turn off Rocket Loader, I get the "Format SQL" option back.

Rocket Loader works by asynchronously loading the javascript, so maybe there was a recent change that doesn't play well with the asynch loading?

I'm up to date with https://github.com/simonw/datasette/commit/e03aed00026cc2e59c09ca41f69a247e1a85cc89

Contributor guide

Research direction
Investigate how the sql formatter JavaScript is loaded in Datasette and why it fails with CloudFlare Rocket Loader. Check if the script depends on synchronous loading or certain DOM readiness. Consider using a script tag with 'defer' or 'async' properly, or initializing the formatter after the script loads.
Tech stack
pythonjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCloudFlare
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65