simonw/datasette

sql-formatter javascript is not now working with CloudFlare rocketloader

Open

#1,969 opened on Dec 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
bughelp wantedjavascript

Description

This is probably not a bug with datasette, but I thought you might want to know, @simonw.

I noticed today that my CloudFlare proxied datasette instance lost the "Format SQL" option. I'm pretty sure it was there last week.

In the CloudFlare settings, if I turn off Rocket Loader, I get the "Format SQL" option back.

Rocket Loader works by asynchronously loading the javascript, so maybe there was a recent change that doesn't play well with the asynch loading?

I'm up to date with https://github.com/simonw/datasette/commit/e03aed00026cc2e59c09ca41f69a247e1a85cc89

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptKnowledge of CloudFlare Rocket Loader
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how the JavaScript for the SQL formatter is loaded in datasette. Look at the relevant commit e03aed00026cc2e59c09ca41f69a247e1a85cc89 to see if any changes were made to script loading. Check if the script has an 'async' or 'defer' attribute or if it is loaded via a dynamic import that conflicts with Rocket Loader. Consider adding a script attribute or ensuring the script loads synchronously when Rocket Loader is active.