simonw/datasette

Cog menu is not keyboard accessible (also no ARIA)

Open

#1,964 opened on Dec 18, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
accessibilitybughelp wanted

Description

This menu here: https://latest.datasette.io/fixtures/attraction_characteristic

You can tab to it (see the outline) and hit space or enter to open it, but you can't then navigate the items in the open menu using the keyboard.

cog-menu

Contributor guide

Tech stack
htmlcssjavascript
Domain
accessibilityfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HTML basicsCSS knowledgeJavaScript event handlingARIA fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the cog menu component in the Datasette repository. The menu is likely rendered via a template (probably in the `templates/` directory) and controlled by JavaScript (look for event listeners in static JS files). The goal is to ensure that when the menu is open, users can navigate items with arrow keys and select with Enter/Space, and that appropriate ARIA roles (e.g., `menu`, `menuitem`) and attributes (e.g., `aria expanded`, `aria activedescendant`) are added. Review existing keyboard handling patterns in the codebase for consistency.