simonw/datasette

Get the tests passing against Windows

Open

#1,627 opened on Feb 3, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
bugcihelp wantedminorwindows

Description

OK, the tests do NOT pass against Windows! https://github.com/simonw/datasette/runs/5044105941

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1626#issuecomment-1028515161

Contributor guide

Tech stack
python
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python testing experienceWindows environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, set up the project on a Windows machine or use CI (GitHub Actions) to replicate the test failures. Examine the test run logs linked in the issue (https://github.com/simonw/datasette/runs/5044105941) to identify specific failing tests. Common Windows issues include file path separators, line endings (CRLF vs LF), and encoding. Investigate the test files in the `tests/` directory for any platform specific assumptions. Once failures are identified, implement fixes such as using `os.path.join` for paths or adding `@pytest.mark.skipif` for platform specific tests. Submit a pull request with the changes.