simonw/datasette

Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key

Open

#1,578 opened on Dec 23, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
bugdocumentationhelp wantedresearch

Description

Found this while working on https://github.com/simonw/datasette-tiddlywiki

Then clicking on /tiddlywiki/tiddlers/%24%3A%2FDefaultTiddlers returns a 404.

Contributor guide

Tech stack
python
Domain
devopsbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic nginx knowledgefamiliarity with URL encoding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, locate the documented nginx proxy configuration in the Datasette repository (likely in docs or examples). Then, set up a local Datasette instance and an nginx proxy using that configuration. Test accessing a row page with a primary key containing special characters (e.g., '%24%3A%2FDefaultTiddlers'). Verify whether the proxy correctly passes the encoded URL or returns a 404. Also check if any nginx rules need to be adjusted to handle URL encoded characters. The existing comments may provide additional context.