simonw/datasette

Get rid of this `restore_working_directory` hack entirely

Open

#1,366 opened on Jun 7, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (625 forks)batch import
help wantedrefactortests

Repository metrics

Stars
 (8,637 stars)
PR merge metrics
 (Avg merge 67d 23h) (19 merged PRs in 30d)

Description

That seems to have fixed it. I'd love to get rid of this restore_working_directory hack entirely.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1361#issuecomment-855308811

Contributor guide

Research direction
Understand the restore working directory hack by examining the referenced issue and related code, then propose a clean alternative or remove it.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65