simonw/datasette

Get rid of this `restore_working_directory` hack entirely

Open

#1366 opened on Jun 7, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (8,637 stars) (625 forks)batch import
help wantedrefactortests

Description

That seems to have fixed it. I'd love to get rid of this restore_working_directory hack entirely.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1361#issuecomment-855308811

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonDatasette internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the codebase for uses of `restore working directory` by searching the repository. Understand the hack's purpose by reading the linked comment in issue #1361. Determine if it can be replaced with a cleaner pattern, such as using context managers or temporary directory changes. Consider testing the change to ensure no regressions.