simonw/datasette-leaflet-freedraw

This still loads Leaflet twice

Open

#5 opened on Jan 25, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (2 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (19 stars)
PR merge metrics
 (PR metrics pending)

Description

My goal with #3 was to avoid loading Leaflet multiple times. But it looks like the leaflet-freedraw.esm.js file weighs in at 873KB because it includes a full copy of Leaflet itself!

Need to figure out how to build FreeDraw as a separate module that doesn't include Leaflet.

Contributor guide

Research direction
Investigate the build configuration (likely webpack/rollup) to mark Leaflet as an external dependency, preventing it from being bundled into leaflet freedraw.esm.js.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70