siddharthkp/bundlesize

Change to master isn't shown in pull request status

Open

#182 opened on Nov 9, 2017

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (4,434 stars) (218 forks)batch import
feature requesthelp wantedquestion

Description

Paraphrased by @siddharthkp

Being able to see the change is very motivating, especially when you're trying to reduce it.

Currently, I can only see the change when clicking on the 'Details' link (The status message is not very helpful)

What can we improve to make the default message better/communicate changes upfront?


Original issue description is folder here:

Do you want to request a feature or report a bug? A bug, although it may be a feature request if this is intentional.

What is the current behavior? Currently, my pull request tells me that I've done a good job and that my bundles are within limits.

If the current behavior is a bug, please provide the steps to reproduce. I have no idea, but here is my configuration:

"bundlesize": [
    {
      "path": "./bundlesize/app.js",
      "maxSize": "75 kB"
    },
    {
      "path": "./bundlesize/vendor.js",
      "maxSize": "350 kB"
    },
    {
      "path": "./bundlesize/app.css",
      "maxSize": "50 kB"
    },
    {
      "path": "./bundlesize/vendor.css",
      "maxSize": "10 kB"
    }
  ]

What is the expected behavior? My pull request doesn't just tell me I did a good job, but also tells me the change in size.

If this is a feature request, what is motivation or use case for changing the behavior? Being able to see the change is very motivating, especially when you're trying to reduce it. Currently, I can only see the change when clicking on the 'Details' link.

Please mention other relevant information.

  • node version 8.9.x
  • npm version not used, yarn 1.3.2
  • Operating system ubuntu
  • bundlesize version 0.15.3
  • CI you are using Codeship

Contributor guide