shuding/cobe

Add cleanup to examples

Open

#27 opened on Apr 17, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (299 forks)user submission
good first issuehelp wanted

Repository metrics

Stars
 (5,298 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The vue and svelte version examples do not have any sort of cleanup when components unmount. There needs to be a call to .destroy() to avoid memory leak.

Contributor guide

Research direction
Investigate the Vue and Svelte example components to add the appropriate cleanup call (e.g., using `onUnmounted` for Vue and `onDestroy` for Svelte) to invoke `.destroy()` on the globe instance.
Tech stack
typescriptvuesvelte
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitVue or Svelte basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75