shuding/cobe

Add cleanup to examples

Open

#27 opened on Apr 17, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (5,298 stars) (299 forks)user submission
good first issuehelp wanted

Description

The vue and svelte version examples do not have any sort of cleanup when components unmount. There needs to be a call to .destroy() to avoid memory leak.

Contributor guide

Tech stack
typescriptvuesvelte
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue lifecycleSvelte lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Find the Vue and Svelte example files in the repository (likely under examples/). For the Vue example, add a call to `.destroy()` in the `beforeUnmount` or `onUnmounted` lifecycle hook. For the Svelte example, use the `onDestroy` lifecycle function. Ensure the globe instance is accessible in the component's scope. Test that the globe is properly destroyed without errors.