showdownjs/showdown

markdown in html is jumping outside of the html element for custom elements

Open

#643 opened on Jan 22, 2019

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (1,640 forks)batch import
help wanted

Repository metrics

Stars
 (13,700 stars)
PR merge metrics
 (Avg merge 15h 21m) (3 merged PRs in 30d)

Description

<span markdown>
**test**

**test**
</span>

<div markdown>
**test**

**test**
</div>

<my-element markdown>
**test**

**test**
</my-element>

turns into

<p><span><strong>test</strong></span></p>
<p><strong>test</strong></p>
<div>
<p><strong>test</strong></p>
<p><strong>test</strong></p>
</div>
<p><span><my-element>test</strong></my-element></p>
<p><strong>test</strong></p>

So I'm assuming showdown is producing valid html, so it won't allow the block element inside the inline element.

But when I use a custom element and set it as a block element, I am still observing the same behaviour.

Is there a way to force showdown to treat it like a block element?

Contributor guide

Research direction
Investigate how showdown classifies custom HTML elements as block vs inline and modify the element type detection to allow custom block elements.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75