shouldjs/should.js

Is it time to deprecate Object.prototype extension?

Open

#146 opened on Jun 20, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,906 stars) (131 forks)batch import
discussionhelp wanted

Description

There's more and more changes like this: https://github.com/nodejs/node/pull/6055 where objects no longer inherit from Object.prototype

Is it time to deprecate this feature in favor of a global variable or something like that?

Feel free to close this if you're tired of discussing Object.prototype, I understand.

Node.js version?

6

Should.js version?

any

How to reproduce it?

try asserting on the result of querystring.parse()

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basicsNode.js ecosystemObject.prototype knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the linked PR (nodejs/node#6055) to understand the change where objects no longer inherit from Object.prototype. Review the should.js codebase for current Object.prototype extension and discuss whether deprecation is appropriate. Consider alternatives like a global variable.