shouldjs/should.js

Is it time to deprecate Object.prototype extension?

Open

#146 opened on Jun 20, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (131 forks)batch import
discussionhelp wanted

Repository metrics

Stars
 (1,906 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There's more and more changes like this: https://github.com/nodejs/node/pull/6055 where objects no longer inherit from Object.prototype

Is it time to deprecate this feature in favor of a global variable or something like that?

Feel free to close this if you're tired of discussing Object.prototype, I understand.

Node.js version?

6

Should.js version?

any

How to reproduce it?

try asserting on the result of querystring.parse()

Contributor guide

Research direction
Investigate the impact of deprecating Object.prototype extension in should.js, review related pull requests and issues, and compare with other assertion libraries.
Tech stack
javascript
Domain
testing
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30