shentao/vue-multiselect

Please support $event on close

Open

#805 opened on Aug 21, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (994 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (6,559 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Please capture the event on close and pass it thou

Steps to reproduce

  <multiselect
      v-model="selected"
      @close="onClose($event)" >
    </multiselect>

Expected behaviour

event is first parameter (mouse or keyboardevent)

Actual behaviour

selected item is first parameter

related: https://github.com/shentao/vue-multiselect/issues/776

Contributor guide

Research direction
Find the close event emission in the source code and change it to pass the native event object as the first argument instead of the selected value.
Tech stack
javascriptvue
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Vue.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80