shentao/vue-multiselect

Please support $event on close

Open

#805 opened on Aug 21, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (6,559 stars) (994 forks)batch import
enhancementgood first issue

Description

Please capture the event on close and pass it thou

Steps to reproduce

  <multiselect
      v-model="selected"
      @close="onClose($event)" >
    </multiselect>

Expected behaviour

event is first parameter (mouse or keyboardevent)

Actual behaviour

selected item is first parameter

related: https://github.com/shentao/vue-multiselect/issues/776

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Vue.js knowledgeUnderstanding of event handling in Vue
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue asks to pass the original event object as the first parameter of the @close event, instead of the selected item. Review the component's source code, likely in src/index.vue, to find where the close event is emitted (e.g., this.$emit('close', ...)). The related issue #776 may provide additional context. Ensure the change is backward compatible or document the breaking change.