shentao/vue-multiselect

Allow a custom (modifier) class for multiselect

Open

#667 opened on Mar 13, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (6,559 stars) (994 forks)batch import
enhancementgood first issue

Description

Hi! I love how multiselect is built using BEM, which nicely matches with our workflow.

However we have several variations of multiselect on our site, and we already have two different styles for these dropdowns. The only possibility I have now is to add styling based on inheritance (eg wrap it in a div), which is kind of anti-BEM ;)

I would prefer to be able to pass a custom prop or option that allows for an additional modifier, so that the base class "multiselect" would become "multiselect multiselect--filter" for example.

Contributor guide

Tech stack
vuejavascriptcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue.js basicsBEM methodologycomponent props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the main component file (likely src/Multiselect.vue) to understand how classes are currently applied using BEM. Look for existing props or computed classes. The feature requires adding a new prop, e.g., `customClass`, which is concatenated to the base 'multiselect' class. Check the render or template where the root element's class is defined. Also review the component's documentation (if any) to ensure consistency. The issue author expects the ability to pass a modifier like ' filter' to create 'multiselect multiselect filter'.