sharkdp/fd

--min-depth is broken for broken symlinks

Open

#1,017 opened on May 12, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (42,984 stars) (1,059 forks)batch import
bughelp wanted

Description

tavianator@tachyon $ ln -s nowhere foo/bar/baz/link
tavianator@tachyon $ fd link foo -L
foo/bar/baz/link
tavianator@tachyon $ fd link foo -L --min-depth=1
tavianator@tachyon $ fd link foo -L --min-depth=0
tavianator@tachyon $

Because:

https://github.com/sharkdp/fd/blob/306cd99273125adb13af74c7801b6fab747fef5d/src/walk.rs#L447-L452

https://github.com/sharkdp/fd/blob/306cd99273125adb13af74c7801b6fab747fef5d/src/walk.rs#L510-L514

Contributor guide

Tech stack
rust
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingFile system basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is in the depth calculation when following broken symlinks (src/walk.rs lines 447-452 and 510-514). The issue shows that min depth is ignored for broken symlinks. The fix likely involves adjusting the depth check for symlink entries. Investigate the logic around these lines, particularly how depth is incremented or set for symlinks. Add a test case with a broken symlink to verify the behavior. Consider using the existing test infrastructure.