sharkdp/fd

--min-depth is broken for broken symlinks

Open

#1,017 opened on May 12, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (1,059 forks)batch import
bughelp wanted

Repository metrics

Stars
 (42,984 stars)
PR merge metrics
 (Avg merge 15d 23h) (16 merged PRs in 30d)

Description

tavianator@tachyon $ ln -s nowhere foo/bar/baz/link
tavianator@tachyon $ fd link foo -L
foo/bar/baz/link
tavianator@tachyon $ fd link foo -L --min-depth=1
tavianator@tachyon $ fd link foo -L --min-depth=0
tavianator@tachyon $

Because:

https://github.com/sharkdp/fd/blob/306cd99273125adb13af74c7801b6fab747fef5d/src/walk.rs#L447-L452

https://github.com/sharkdp/fd/blob/306cd99273125adb13af74c7801b6fab747fef5d/src/walk.rs#L510-L514

Contributor guide

Research direction
Investigate the depth filtering logic in walk.rs, specifically how symlinks are handled when using L and min depth. Identify why the depth is not correctly adjusted for broken symlinks.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50