sharkdp/dbg-macro

CMake < 3.10 deprecation.

Open

#142 opened on Jan 24, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (276 forks)github user discovery
good first issue

Repository metrics

Stars
 (3,231 stars)
PR merge metrics
 (PR metrics pending)

Description

I suggest updating CMakeLists.txt to set cmake_minimum_required to a version >= 3.10 or, as the non-suppressable CMake warning says, use the <min>...<max> syntax.

Here's the warning that constantly grabs attention when using this library:

CMake Deprecation Warning at build/_deps/dbg-macro-src/CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.10 will be removed from a future version of CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.

Since I include the library by using FetchContent I can't manually change the library's CMakeLists.txt persistently, without losing the flexibility of using FetchContent.

Contributor guide

Research direction
Edit the first line of CMakeLists.txt to change `cmake minimum required(VERSION 3.9)` to `cmake minimum required(VERSION 3.10...3.27)` or a version >= 3.10. Ensure compatibility with the project's required CMake features.
Tech stack
ccpp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90