sharkdp/bat

Moving to the end of 6 Mb file takes forever

Open

#304 opened on Sep 11, 2018

View on GitHub
 (14 comments) (13 reactions) (0 assignees)Rust (58,889 stars) (1,557 forks)batch import
help wantedperformance

Description

I am not really sure if this is an issue or intended behaviour. It took me forever to move to end of a 6Mb file.

Steps to reproduce:

  • $ seq 1 1000000 > test
  • $ bat test Press G to move to end of the file. This step took a long time. It seems bat was going through the file sequentially.

Apologies, if this is not the place to ask this question or this is a known bug/feature.

Contributor guide

Tech stack
rust
Domain
cli
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingFile I/O concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate why moving to the end of a large file takes long in bat. The issue suggests it reads sequentially. Look at the file reading and syntax highlighting code in src/bin/bat/main.rs or the pager module. Consider using file metadata to seek to the end directly. Check the issue comments for any proposed solutions.