sharkdp/bat

[windows] fzf integration sample from readme does not work

Open

#2,095 opened on Feb 28, 2022

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Rust (1,557 forks)batch import
documentationhelp wantedwindows

Repository metrics

Stars
 (58,889 stars)
PR merge metrics
 (Avg merge 16d 6h) (11 merged PRs in 30d)

Description

Hi,

On windows the fzf integration sample does not work out of the box.

https://github.com/sharkdp/bat/blob/7be9485c3690799ee204ec5195172f9e90f49924/README.md?plain=1#L121

❯ fzf --preview 'bat --color=always --style=numbers --line-range=:500 {}'
invalid color specification: always

You have to use " instead of ':

❯ fzf --preview "bat --color=always --style=numbers --line-range=:500 {}"

Maybe you can leave a note for windows users.

Contributor guide

Research direction
Update the README example to use double quotes around the bat command in the fzf preview example for Windows users.
Tech stack
rust
Domain
cli
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90