sharkdp/bat

[windows] fzf integration sample from readme does not work

Open

#2,095 opened on Feb 28, 2022

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Rust (58,889 stars) (1,557 forks)batch import
documentationhelp wantedwindows

Description

Hi,

On windows the fzf integration sample does not work out of the box.

https://github.com/sharkdp/bat/blob/7be9485c3690799ee204ec5195172f9e90f49924/README.md?plain=1#L121

❯ fzf --preview 'bat --color=always --style=numbers --line-range=:500 {}'
invalid color specification: always

You have to use " instead of ':

❯ fzf --preview "bat --color=always --style=numbers --line-range=:500 {}"

Maybe you can leave a note for windows users.

Contributor guide

Tech stack
rustshell
Domain
documentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Update the README.md at the referenced line (L121) to include a note that on Windows, double quotes should be used instead of single quotes in the fzf preview command. For example, change the example to use double quotes and add a comment about Windows compatibility.